Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pilota-build): init service should set cur item #237

Merged
merged 1 commit into from
Apr 8, 2024
Merged

fix(pilota-build): init service should set cur item #237

merged 1 commit into from
Apr 8, 2024

Conversation

PureWhiteWu
Copy link
Member

Motivation

CUR_ITEM should be set to indicate the current item.

Solution

Set it in get_init_service.

@PureWhiteWu PureWhiteWu added A-pilota-build This issue concerns the `pilota-build` crate. C-bug This is a bug-report. Bug-fix PRs use `C-enhancement` instead. labels Apr 7, 2024
@PureWhiteWu PureWhiteWu self-assigned this Apr 7, 2024
@PureWhiteWu PureWhiteWu requested review from a team as code owners April 7, 2024 16:28
@PureWhiteWu PureWhiteWu merged commit 0f00b20 into main Apr 8, 2024
11 checks passed
@PureWhiteWu PureWhiteWu deleted the fix/init_cur_item branch April 8, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ggiggle Ggiggle Ggiggle approved these changes

Assignees

@PureWhiteWu PureWhiteWu

Labels
A-pilota-build This issue concerns the `pilota-build` crate. C-bug This is a bug-report. Bug-fix PRs use `C-enhancement` instead.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PureWhiteWu @Ggiggle