Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pilota): align the inner buffer index with the protocol index #248

Merged
merged 1 commit into from
May 28, 2024
Merged

fix(pilota): align the inner buffer index with the protocol index #248

merged 1 commit into from
May 28, 2024

Conversation

Ggiggle
Copy link
Contributor

@Ggiggle Ggiggle commented May 28, 2024

Motivation

The previous advance won't align the inner buffer index with the input protocol index, so the reading of inner buffer might encounter error.

Solution

Align these two indexes for correctness of input protocol.

@Ggiggle Ggiggle requested review from a team as code owners May 28, 2024 10:16
@Ggiggle Ggiggle merged commit a6accca into main May 28, 2024
10 checks passed
@Ggiggle Ggiggle deleted the fix/input_proto_advance branch May 28, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PureWhiteWu PureWhiteWu PureWhiteWu approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ggiggle @PureWhiteWu