feat: generate faststr for thrift string #73

Millione · 2022-12-07T08:54:06Z

Motivation

struct A {
    1: required string faststr,
    2: required string string(pilota.rust_type = "string"),
}

Generated:

pub struct A {
    pub faststr: ::pilota::FastStr,
    pub string: ::std::string::String,
}

pilota/src/thrift/binary.rs

PureWhiteWu · 2022-12-07T09:41:21Z

pilota/src/thrift/binary.rs

+    fn read_faststr(&mut self) -> Result<FastStr, Error> {
+        let len = self.trans.read_i32()? as usize;
+        let bytes = self.trans.split_to(len);
+        if len >= ZERO_COPY_THRESHOLD {


这里有必要么？是不是直接全部走 zero copy 就行了？

小string的情况下还是Arc<str>更好吧

Millione force-pushed the lj/dev branch from fbed2bd to 774c07c Compare December 7, 2022 09:26

PureWhiteWu reviewed Dec 7, 2022

View reviewed changes

feat: generate faststr for thrift string

fd341de

Millione force-pushed the lj/dev branch from 774c07c to fd341de Compare December 7, 2022 10:21

PureWhiteWu approved these changes Dec 7, 2022

View reviewed changes

PureWhiteWu merged commit d2e3759 into cloudwego:main Dec 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: generate faststr for thrift string #73

feat: generate faststr for thrift string #73

Millione commented Dec 7, 2022 •

edited

Loading

PureWhiteWu Dec 7, 2022

Millione Dec 7, 2022 •

edited

Loading

feat: generate faststr for thrift string #73

feat: generate faststr for thrift string #73

Conversation

Millione commented Dec 7, 2022 • edited Loading

Motivation

PureWhiteWu Dec 7, 2022

Choose a reason for hiding this comment

Millione Dec 7, 2022 • edited Loading

Choose a reason for hiding this comment

Millione commented Dec 7, 2022 •

edited

Loading

Millione Dec 7, 2022 •

edited

Loading