fix: Add sort ascending by string length in versions.tf files keys array #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
pushed a commit
that referenced
this pull request
Nov 12, 2022
## [1.2.1](v1.2.0...v1.2.1) (2022-11-12) ### Bug Fixes * Add sort ascending by string length in versions.tf files keys array ([#15](#15)) ([8250970](8250970))
|
🎉 This PR is included in version 1.2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi!
Added a simple fix to sort ascending the array keys of versions.tf files. With this we can ensure that the first value will be the versions.tf file of the root path.
Motivation and Context
The motivation for this change is to solve the problem of PR terraform-aws-modules/terraform-aws-alb#264
How Has This Been Tested?
Example of the array obtained in different cases.
Screenshots (if appropriate):