Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated output page #2732

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

updated output page #2732

wants to merge 1 commit into from

Conversation

adipose
Copy link

@adipose adipose commented Apr 12, 2024

image

image

image

image

@bibsp
Copy link

bibsp commented Apr 12, 2024

Limited features (Click to know more)
Maybe?

@adipose
Copy link
Author

adipose commented Apr 12, 2024

It's a hover.

@bibsp
Copy link

bibsp commented Apr 12, 2024

Yes. Hover is not something everybody will do. That's why I thought.

@adipose
Copy link
Author

adipose commented Apr 12, 2024

Yes. Hover is not something everybody will do. That's why I thought.

Tooltips don't work on click. I tried it but I didn't like it. Perhaps it can say "mouse over" or something.

@bibsp
Copy link

bibsp commented Apr 12, 2024

Nice, mouse hover is also okay. Some kind of message is required, so that average users can know what are those unsupported features.
But, wait for clsid's final suggestion.

@clsid2
Copy link
Owner

clsid2 commented Apr 14, 2024

I am leaning towards just adjusting the renderer tooltips to have a much more detailed description of their capabilities. Then the above layout would be fine. But the limited features label could be removed.

@bibsp
Copy link

bibsp commented Apr 14, 2024

fff
ffff
Edited images, if you like this idea.

@adipose
Copy link
Author

adipose commented Apr 14, 2024

I made a clickable popup before but it seemed a bit of overkill.

I don't like trying to fit all the checks into a fixed space. Especially considering translations.

Popup with all features and checkmarks seems ok. Perhaps one global indicator that reads "current configuration does not support all features" and a separate always on button to popup the feature report.

@clsid2
Copy link
Owner

clsid2 commented Apr 14, 2024

Perhaps just a single universal icon to indicate capabilities:

  • green checkmark: all supported (MPCVR/MadVR)
  • yellow warning: almost all supported (EVR-CP/Sync which have no HDR support)
  • red warning: for old renderers

Icon shows same tooltip as the selected video renderer. I plan to rewrite those tooltips to show all important information.

Audio/subtitle renderers shouldn't show any extra icon or info. Just an informative tooltip.

@NBruderman
Copy link

Perhaps just a single universal icon to indicate capabilities:

  • green checkmark: all supported (MPCVR/MadVR)
  • yellow warning: almost all supported (EVR-CP/Sync which have no HDR support)
  • red warning: for old renderers

Icon shows same tooltip as the selected video renderer. I plan to rewrite those tooltips to show all important information.

Audio/subtitle renderers shouldn't show any extra icon or info. Just an informative tooltip.

I mean, we can go even further, as MPCVR supports DV, and madvr doesn't.
But that might be nitpicking.

@clsid2
Copy link
Owner

clsid2 commented Apr 15, 2024

Such details will be put in tooltip.

@adipose
Copy link
Author

adipose commented May 20, 2024

@clsid2 , what would you like to me to do for this? Should I wait for the updated notes?

@clsid2
Copy link
Owner

clsid2 commented May 20, 2024

Yeah, lets wait until that is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants