Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signal handling support for SIGINT and SIGTERM #150

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

clue
Copy link
Owner

@clue clue commented Apr 19, 2022

This changeset adds signal handling support for SIGINT and SIGTERM.

Updating the Dockerfile instructions to take advantage of this in Docker containers is left up for a follow-up PR once this PR and #149 are merged.

As discussed in #144
Refs #149 and #136 as this improves Docker support somewhat, in particular because docker stop will send a SIGTERM by default
Refs #128 as the implementation is in contrast to the fiber compatibility mode that tries to keep the loop running by restarting it automatically

@clue clue added the new feature New feature or request label Apr 19, 2022
@clue clue requested a review from SimonFrings April 19, 2022 21:53
@SimonFrings SimonFrings merged commit 613b437 into clue:main Apr 20, 2022
@clue clue deleted the signals branch April 20, 2022 08:32
@drupol
Copy link

drupol commented Apr 20, 2022

Nice !

I just did:

git checkout main
git pull
git checkout feat/use-nix
git rebase main
git push origin --force

And the Nix and Docker images were updated ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants