Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only try to follow redirects if Location response header is present #130

Merged
merged 1 commit into from
Apr 3, 2019

Conversation

clue
Copy link
Owner

@clue clue commented Apr 3, 2019

Only try to follow redirects with 3xx (Redirection) response status if response contains a Location response header. This fixes 304 (Not Modified) and 300 (Multiple Choices) responses which usually do not include a Location response header.

See also https://stackoverflow.com/questions/16194988/for-which-3xx-http-codes-is-the-location-header-mandatory

Resolves #128

@clue clue added the bug label Apr 3, 2019
@clue clue added this to the v2.6.0 milestone Apr 3, 2019
@clue clue merged commit 02eee38 into clue:master Apr 3, 2019
@clue clue deleted the redirect-location branch April 3, 2019 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not try to follow 304 (Not Modified) response
1 participant