Skip to content
This repository has been archived by the owner on Oct 19, 2021. It is now read-only.

Fixes to support CS2 #596

Merged
merged 17 commits into from
Oct 2, 2017
Merged

Fixes to support CS2 #596

merged 17 commits into from
Oct 2, 2017

Conversation

swang
Copy link
Collaborator

@swang swang commented Mar 13, 2017

Still 3 broken tests, 1 test is due to possibly to bug described here: jashkenas/coffeescript#4463

@GeoffreyBooth
Copy link

jashkenas/coffeescript#4463 has been fixed in jashkenas/coffeescript#4485

@GeoffreyBooth GeoffreyBooth mentioned this pull request Apr 15, 2017
Closed
@renchap
Copy link

renchap commented Jul 2, 2017

The brand new JSX syntax in CS2 also needs to be handled.

@GeoffreyBooth
Copy link

The JSX syntax is especially important for a linter to handle. In the docs I recommend people always put spaces on either side of < and >, e.g. i < 1 rather than i<1, to disambiguate comparisons from JSX tags. In the compiler we tried to be as lenient as possible about this, to minimize the breaking change for people who have e.g. i<1 in their code, by doing what we can to detect when < is being used to compare instead of delimit a JSX tag; in this example, the 1 is a tip-off, because JSX tags can’t begin with numbers. But while the compiler tries to be forgiving, the linter should be the opposite, throwing warnings wherever a < or > appears to be used in a comparison (such as when there’s no matching closing < or > symbol).

swang added 12 commits July 13, 2017 02:13
@swang
groundskeeping: update coffee-script package to 1.12.6
53fd6ea
@swang
space_operators: remove LOGIC token, add &&, ||, &, |, ^ tokens
17468a8 
LOGIC tokens were taken out in ~1.12.x and replaced with '&&', '||',
'&', '|' related tokens.
@swang
prefer_english_operator: replace LOGIC token with &&, || tokens
a167d5c 
LOGIC tokens were removed in ~12.1.x so this just updates with the new
token names
@swang
no_implicit_braces: fixed some false positives
54b8b9f 
Closes #605, #606

* fix bug when class had @ in its name
* fixed rule to better detect the end of the class
@swang
no_implicit_parens: fix in 1.12.6
c07b730 
now does an extra check to make sure CALL_START aren't on the same line
@swang
coffeelint: update to coffeescript@next
b161f23 
update references of coffee-script to coffeescript
@swang
no_implicit_parens: fix for new cs2 parser
5385d3e
@swang
space_operators: LOGIC tokens removed in cs2
e98efa9
@swang
missing_fat_arrows: fix change in cs2 wrt default parameters
26cfd56
@swang
no_unnecessary_fat_arrows: super is no longer allowed in normal funct…
9ec5612 
…ions in cs2
@swang
test_commandline: fix custom rules test
f6de59c
@swang
travis.yml: only check latest node versions
329d3f3
@kieran
Copy link

kieran commented Jul 20, 2017

Is this being merged?

@eugenet8k eugenet8k mentioned this pull request Aug 3, 2017
Closed
@renchap renchap mentioned this pull request Sep 3, 2017
Closed
@renchap
Copy link

renchap commented Sep 18, 2017

Coffeescript 2 is now released: http://coffeescript.org/announcing-coffeescript-2/
It would be awesome to have support for it in coffeelint soon :)

@swang
package.json: set coffeescript to 2.0.0; node >= 6.9.1
a393a00
@swang
Cakefile: update coffeescript package
183221c
@swang
vowsrunner: change coffee-script to coffeescript
20699ac
@swang
no_backticks: ignore ### comments ### meant for type annotation
f262551
@swang
test_reporters: make PassThrough/Raw reporter class compatible
540546d 
Right now you cannot interop CS and ES2015 classes. Since tests are run by
using vows, which uses JS, RawReporter is being imported as a ES2015
class, while PassThroughReporter is a CS class.

This fixes the issue of the two classes being different class types by
making them both ES2015 classes.
@swang
Copy link
Collaborator Author

swang commented Sep 19, 2017

All test pass. If you want to try out CS2 support feel free to point to this branch. It is late here, so I want to wait until I have time to monitor when the library before publishing to npm.

This was referenced Sep 19, 2017
Closed
Closed
@boris-petrov
Copy link

@swang - thank you for the support. As I wrote here: #595 - I'm getting an error when installing the cs2 branch. The same error happens with your new commits. Any ideas what's going on?

@swang
Copy link
Collaborator Author

swang commented Sep 19, 2017

Sorry it's a bit late here so I'm not going to be able to look at this until tomorrow. I'm guessing npm installing a branch was never viable.

@boris-petrov
Copy link

No problem, good night, we can wait a bit more. :) Thanks again for the support, we all appreciate it!

It's kind of strange because this file IS there. Also I've npm-installed packages from GitHub branches before... not sure what the issue is.

@danielbayley
Copy link
Contributor

I also ran into errors trying to install with npm using their git:user/repo#branch syntax.

Although I happen to already have a local clone from contributing other PRs, so I checked out the cs2 branch and have been using that via npm link, so far with no errors, and all tests pass for me also. So hopefully @swang, this should be good to go?

@danielbayley danielbayley mentioned this pull request Sep 22, 2017
Closed
@boris-petrov
Copy link

@swang - could you merge this and release a new version please? :)

@swang swang merged commit 1946c12 into master Oct 2, 2017
@swang swang deleted the cs2 branch October 2, 2017 03:54
@davehenton davehenton mentioned this pull request Dec 5, 2017
Open
This was referenced Feb 19, 2018
Closed
Closed
@jacksonrayhamilton jacksonrayhamilton mentioned this pull request Jan 17, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@swang @GeoffreyBooth @renchap @kieran @boris-petrov @danielbayley