StaticFlags: Implement CANNOT_TURN #536
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insunaa
commented
Aug 9, 2024
|
|
||
| o = (i_faceTarget ? owner.GetAngle(i_target.getTarget()) : i_target->GetOrientation()); | ||
| if (owner.CannotTurn()) | ||
| o = owner.GetOrientation(); |
There was a problem hiding this comment.
maybe
return false;?
There was a problem hiding this comment.
This is prolly not necessary. Likely client will handle the "not turning", i.e. when npc has smth in crosshairs, then client wont turn npc to it
There was a problem hiding this comment.
Yes, but I've also seen cases with Kologarn for example where he's not supposed to turn, but then when he dies and plays his death animation his corpse falls sideways, or he turns for a millisecond while doing an attack and then snaps back forward, so I added this to be safer, I guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
This PR implements CreatureStaticFlags3::CANNOT_TURN