SqlRole: Fix default for $ServerName #1
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Fixed:
ServerName
paramer is optional and defaults to$env:COMPUTERNAME
, butTest-TargetResource
uses$PSBoundParameters
which ignores default values for parameters. Looks like this was fixed by BREAKING CHANGE: SqlServerDsc: Make parameter ServerName non-mandatory dsccommunity/SqlServerDsc#1503 in several other places such asSqlDatabasePermission
but was missed here.This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).