Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce shuffle trick to get more local P-values #1774

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

vbcwonderland
Copy link
Collaborator

Sampling by shuffle threshold and get P Values for each shuffle group. The result pVals_list will then being used in other methods.
For example: generate each of its own coresponding Anderson-Darling Test P Value.

Copy link
Collaborator

@jdramsey jdramsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this: int shuffleTimes = (int) Math.ceil(1 / shuffleThreshold);
be this?: int shuffleTimes = (int) Math.ceil(sampleSize / shuffleThreshold);

for some sample size?

@vbcwonderland
Copy link
Collaborator Author

Hi Joe,

I think it should be (int) Math.ceil(1 / shuffleThreshold) because the shuffleThreshold here is a decimal, e.g. 0.3.
Then in order to cover all samples at least statistically for once (i.e. no shuffle, use the whole sample), we should do int) Math.ceil(1 / shuffleThreshold) so that it can achieve the same. e.g. 1 / 0.3 = 3.333 -> round up to 4 times, would make sure if we take 30% of our current data for 4 times, we would expect to use all data points for once.

Best,
Verity

@jdramsey
Copy link
Collaborator

Oh i see what you mean... let me go over this again now.

Copy link
Collaborator

@jdramsey jdramsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jdramsey jdramsey merged commit 7795487 into development May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants