fix: false positive pyodide build cache hits #838
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, we will get false positive cache hits
|
Is this still relevant? |
|
It is. I will need to dramatically simplify the pyodide build flow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we used the built Pyodide package version as the cache key exclusively.
This yielded false positive cache hits when only the source code of a module changed (the sha256 signature), but not its version, as no official release took place. Therefore, we kept reusing built modules even though they were obsolete.
This PR introduces a fix by using
{version}@{sha256}as the hash key.Technically,
{sha256}would be sufficient as a key, but including the version aids debugging.