Fix C++20 compatibility issues and faster integer hashing #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in TestParallel tests
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #55 +/- ##
==========================================
+ Coverage 96.58% 96.69% +0.11%
==========================================
Files 51 51
Lines 3454 3452 -2
==========================================
+ Hits 3336 3338 +2
+ Misses 118 114 -4
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
DanielLiamAnderson
changed the title
|
Performance test results attached. The performance of grouping and deduplicating algorithms is improved by up to 23%. |
This was referenced Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#53 identifies some issues with the
atomic_wait/atomic_notifyinterface. The signatures of the wait and notify methods from the sample implementation do not match those in the C++20 standard, and the fallback when the standard library already implements them uses aliases which do not permit type deduction. This fixes both of those issues.Some other compile issues with C++20 enabled have also been fixed, including some cases of aggregate initialization in
TestParallelwhich are no longer valid, and the packed struct extension used insequence_base, which wasn't applied widely enough.This patch also addresses #40 by changing the hashing function Parlay uses for integer types. This corrects the performance regression in the grouping and deduping algorithms observed post-PR #22.