Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thread_id_pool.h: mark variable as [[maybe_unused]] #69

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

wheatman
Copy link
Contributor

@wheatman wheatman commented Jan 9, 2024

mark a variable only used in an assert as [[maybe_unused]] so that non debug builds don't give warnings when compiling with -Wunused-but-set-variable

parlaylib/include/parlay/internal/../internal/../internal/thread_id_pool.h:50:12: warning: variable 'num_destroyed' set but not used [-Wunused-but-set-variable]
   50 |     size_t num_destroyed = 0;

mark a variable only used in an assert as [[maybe_unused]] so that non debug builds don't give warnings when compiling with `-Wunused-but-set-variable`

```
parlaylib/include/parlay/internal/../internal/../internal/thread_id_pool.h:50:12: warning: variable 'num_destroyed' set but not used [-Wunused-but-set-variable]
   50 |     size_t num_destroyed = 0;
```
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f8e38c7) 96.84% compared to head (604e34f) 96.87%.

❗ Current head 604e34f differs from pull request most recent head e4ff9a6. Consider uploading reports for the commit e4ff9a6 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   96.84%   96.87%   +0.02%     
==========================================
  Files          56       56              
  Lines        3708     3708              
==========================================
+ Hits         3591     3592       +1     
+ Misses        117      116       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanielLiamAnderson DanielLiamAnderson merged commit c655b8f into cmuparlay:master Jan 15, 2024
40 checks passed
@wheatman wheatman deleted the patch-2 branch January 15, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants