Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save and load config file (format) for decoder #289

Closed
lenzo-ka opened this issue Aug 31, 2022 · 3 comments · Fixed by #307
Closed

Save and load config file (format) for decoder #289

lenzo-ka opened this issue Aug 31, 2022 · 3 comments · Fixed by #307
Milestone

Comments

@lenzo-ka
Copy link
Contributor

It would be a nice piece of sugar to be able to load and write configurations from the API (and/or cli args). This would make it easy to re-run things with the same arguments (replicating results and usinga setup on new items), and also open it up to editing the config file to change startup params. Could also potentially contain adapted cmn parameters.

@lenzo-ka
Copy link
Contributor Author

It would be super to have a verbose save that actually includes the values for all parameters, rather than just the ones that are "set" (or differ from defaults).

@dhdaines
Copy link
Contributor

Yes, this is a good idea and I will do it. Possibly just the "argfile" format that is already supported (but not for saving) even though something like YAML would obviously be a lot nicer.

@dhdaines dhdaines added this to the 5.0.0 milestone Sep 7, 2022
@dhdaines
Copy link
Contributor

Implemented in #295 with ps_config_serialize_json() - may need a bit of tweaking, currently it is not saving string parameters that are NULL but I think it should save them since that might not be the default value

@dhdaines dhdaines linked a pull request Sep 29, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants