Vade retro sphinxbase #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
still need to figure out what to do about a few of them
... and do nothing about it for the moment (except remove a useless internal include)
If there was some good reason for these, I no longer remember what it was
seems to be just numerical differences (lots of float32->float64 changes so unsurprising)
dhdaines
force-pushed
the
vade_retro_sphinxbase
branch
from
264a42d
to
206ff35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big, huge, dramatic API change (as promised, vaguely). SphinxBase is no more, and the configuration API has changed quite a bit - options are no longer "command-line arguments" and thus are no longer prefixed with dashes when calling
ps_config_*functions. This will break your code (unless it is in Python, in which case you should be okay).This came from a desire to repatriate the configuration API into
<pocketsphinx.h>and also make it a proper ABI instead of some random macros. It became obvious that there was no way to do this without pulling in a lot of headers that, to put it charitably, have seen better days. There was a huge mess of cross-inclusion and lots of functions and structures that really shouldn't exist, but certainly shouldn't be made public.Some of the other SphinxBase APIs have also been repatriated, namely the LM and FSG. I have only exposed functions that don't depend on internal implementation details. The Python bindings have privileged access to internal stuff, but it should be possible to write reasonable
$OTHER_LANGUAGEbindings using the public headers - one of the goals here is to make it easier to use FFI or, yes, that other thing that starts with S and ends with G.