-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added jsgf/fsg tags extraction #84
base: master
Are you sure you want to change the base?
Conversation
Thank you, did you read #13 ? |
Hi, |
Ok, I'll leave it open for now |
when I type "make clean all", I encounter the following error “../../src/libpocketsphinx/.libs/libpocketsphinx.so: undefined reference to `fsg_link_tag' |
@@ -1048,8 +1137,16 @@ fsg_search_hyp(ps_search_t *search, int32 *out_score) | |||
--c; | |||
*c = ' '; | |||
} | |||
|
|||
ps_hyptags_t *r = (ps_hyptags_t *)ckd_calloc(1, sizeof(ps_hyptags_t)); | |||
strncpy(r->tag,fsg_link_tag(fl),MAX_TAG_SIZE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fsg_link_tag isn't defined
Hi! This is a good idea, the tags never were completely implemented. The discussion in #13 is interesting. Commercial ASR aplications have been moving away (slowly) from grammar-based recognition for the last decade or so, because combining LVCSR using a language model (or perhaps some horrific end-to-end blob of Derp Learning) with a robust parser is generally more, well, robust, and also more accurate. All this is true under the assumption that recognition is Done In The Cloud on some constantly expanding farm of servers. It's less obvious for the sort of environments and applications for which PocketSphinx was originally designed. Unfortunately this PR doesn't quite work with the current layout of the codebase :) if you have the time to update it I would appreciate that... |
Together with the pull request on sphinxbase, with this update it would be possible to extract tags from jsgf grammars.
Two functions on pocketsphinx.h/c were added, one to get the result not just as a simple const char* hyp, but as a complex glist_t (ps_get_hyp_with_tags), which would then be accessed through the other function on pocketsphinx (ps_get_word_and_tags).