This repository has been archived by the owner on Feb 13, 2024. It is now read-only.
Update fontations to 0.1.0 and update fea-rs to 0.3.0 to unblock fontmake-rs #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsheeter
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks googlefonts/fontc#123 which is currently stuck on
mismatched types
struct write_fonts::font_builder::FontBuilder and struct FontBuilder have similar names, but are actually distinct types
perhaps two different versions of crate write_fonts are being used?rustcClick for full compiler diagnostic
Because fea-rs is on 0.0.5, the rest of fontmake-rs is on 0.0.6, and that's a compile error.
Also ... I seem to own fea-rs on crates.io but not have write access to the repo. Should I? Or should we make a copy under googlefonts?