Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for "TRADEMARKS" #33

Open
caniszczyk opened this issue Feb 9, 2022 · 2 comments
Open

Add check for "TRADEMARKS" #33

caniszczyk opened this issue Feb 9, 2022 · 2 comments

Comments

@caniszczyk
Copy link

CNCF Projects have to xfer their trademark over to the foundation.

There's no easy way to check for this but @amye were chatting that we may have a new policy in CNCF to have a "TRADEMARKS" file at the root of the repo that essentially links to https://www.linuxfoundation.org/trademark-usage/ after we confirm the paperwork is sent our way

@matthewpereira
Copy link
Contributor

Hey folks, it looks like clomonitor currently looks for a trademark statement with the following regex:

"https://(?:w{3}\.)?linuxfoundation.org/trademark-usage"

However, the Linux Foundation's website has a different URL (maybe they updated it): https://www.linuxfoundation.org/legal/trademark-usage

Currently, https://www.linuxfoundation.org/trademark-usage redirects to https://www.linuxfoundation.org/legal/trademark-usage , but relying on that forever seems like a potential pitfall. This also presents some friction to people that might copy the URL from the real trademark usage page, and then find they're still failing the clomonitor check.

It seems like it might be a good idea to change the regex to the following:

"https://(?:w{3}\.)?linuxfoundation.org/legal/trademark-usage"

Or, if you want to allow for some backward compatibility,

"https://(?:w{3}\.)?linuxfoundation.org/(?:legal/)?trademark-usage"

I'm happy to make a PR, let me know if you prefer one option or the other, or if this is already being handled elsewhere.

@tegioz
Copy link
Contributor

tegioz commented Dec 16, 2022

Hi @matthewpereira 👋

A PR sounds great, thanks! I think it's better if we keep the backwards compatible option for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants