Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trademark_disclaimer to allow for new URL #797

Closed
wants to merge 11 commits into from
Closed

Update trademark_disclaimer to allow for new URL #797

wants to merge 11 commits into from

Conversation

matthewpereira
Copy link
Contributor

@matthewpereira matthewpereira commented Dec 16, 2022

In order to account for The Linux Foundation's new /legal/trademark-usage route, this regex on line 20 adds an optional legal/ capture group.

Review and feedback appreciated. 🙇

Addresses comments in #33 .

Copy link
Contributor

@tegioz tegioz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @matthewpereira! One minor detail and this is ready to go 🙂

tegioz
tegioz previously approved these changes Dec 19, 2022
Copy link
Contributor

@tegioz tegioz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me @matthewpereira, thanks!

@tegioz
Copy link
Contributor

tegioz commented Dec 19, 2022

@matthewpereira can you format the trademark_disclaimer.rs file with rustfmt to fix the failed job? Thanks!

@tegioz
Copy link
Contributor

tegioz commented Dec 20, 2022

And also rebase from main if you don't mind, we've just merged another PR. Thanks!

matthewpereira and others added 11 commits December 23, 2022 19:41
In order to account for The Linux Foundation's new `/legal/trademark-usage` route, this regex on line 20 adds an optional `legal/` capture group.

Signed-off-by: Matthew Pereira <[email protected]>
Signed-off-by: Administrator <[email protected]>
Signed-off-by: Matthew Pereira <[email protected]>
Signed-off-by: Administrator <[email protected]>
Signed-off-by: Matthew Pereira <[email protected]>
Signed-off-by: Administrator <[email protected]>
Signed-off-by: Cintia Sanchez Garcia <[email protected]>
Signed-off-by: Administrator <[email protected]>
Signed-off-by: Cintia Sanchez Garcia <[email protected]>
Signed-off-by: Administrator <[email protected]>
Related to #761

Signed-off-by: Sergio Castaño Arteaga <[email protected]>
Signed-off-by: Cintia Sanchez Garcia <[email protected]>
Co-authored-by: Sergio Castaño Arteaga <[email protected]>
Co-authored-by: Cintia Sanchez Garcia <[email protected]>
Signed-off-by: Administrator <[email protected]>
Signed-off-by: Sergio Castaño Arteaga <[email protected]>
Signed-off-by: Administrator <[email protected]>
Signed-off-by: Sergio Castaño Arteaga <[email protected]>
Signed-off-by: Administrator <[email protected]>
Signed-off-by: Bill Mulligan <[email protected]>
Signed-off-by: Administrator <[email protected]>
Signed-off-by: Sergio Castaño Arteaga <[email protected]>
Signed-off-by: Administrator <[email protected]>
@matthewpereira
Copy link
Contributor Author

I think I've made a mess of this, due to working on my personal machine over the holidays instead of continuing on my work machine. 🙃 I'm going to start fresh with a clean PR if that's alright with y'all.

@tegioz
Copy link
Contributor

tegioz commented Dec 24, 2022

Sure, no problem 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants