-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Workflow that automatically add a comment based on labels #2389
Conversation
Signed-off-by: Seokho Son <[email protected]>
Signed-off-by: Seokho Son <[email protected]>
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
FYI. Tested in m-cmp/mc-infra-manager#7 |
PTAL: @jihoon-seo @iamNoah1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple tweaks, thanks for this @seokho-son
.github/auto-comment-config.yaml
Outdated
label_mappings: | ||
- labels: | ||
- hold | ||
comment: Wait, please do not proceed this yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment: Wait, please do not proceed this yet. | |
comment: Wait, please do not proceed with this yet. |
.github/auto-comment-config.yaml
Outdated
comment: Wait, please do not proceed this yet. | ||
- labels: | ||
- lang/en | ||
comment: To see where this is in the review pipeline and follow the progress, please have a look at the [project board](https://github.com/orgs/cncf/projects/26/views/1). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment: To see where this is in the review pipeline and follow the progress, please have a look at the [project board](https://github.com/orgs/cncf/projects/26/views/1). | |
comment: To see where this is in the review pipeline and follow the progress, please look at the [definition review board](https://github.com/orgs/cncf/projects/26/views/1). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nate-double-u for the enhancement!
Applied your comment as suggested!
Signed-off-by: Seokho Son <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @seokho-son, /lgtm
Describe your changes
This PR add a Workflow that automatically add a comment based on labels.
Related issue number or link (ex:
resolves #issue-number
)https://docs.google.com/document/d/1kjNrLWbMHSQ3x4ob8Q_lNOoJ4f8uPQcuD9a0Sif24NY/edit?pli=1
Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.