Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Workflow that automatically add a comment based on labels #2389

Merged
merged 3 commits into from
Sep 16, 2023

Conversation

seokho-son
Copy link
Collaborator

Describe your changes

This PR add a Workflow that automatically add a comment based on labels.

Related issue number or link (ex: resolves #issue-number)

Add an automation for every incoming PR that says something like: “To see where this is in the review pipeline and follow the progress, please have a look at the project board

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@netlify
Copy link

netlify bot commented Sep 13, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 0964489
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6503ba87bc3ebd00082696d5
😎 Deploy Preview https://deploy-preview-2389--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@seokho-son
Copy link
Collaborator Author

FYI. Tested in m-cmp/mc-infra-manager#7

image

@seokho-son seokho-son added the maintainers Use this label if PR requires maintainers to take action label Sep 13, 2023
@seokho-son
Copy link
Collaborator Author

PTAL: @jihoon-seo @iamNoah1

Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple tweaks, thanks for this @seokho-son

label_mappings:
- labels:
- hold
comment: Wait, please do not proceed this yet.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
comment: Wait, please do not proceed this yet.
comment: Wait, please do not proceed with this yet.

comment: Wait, please do not proceed this yet.
- labels:
- lang/en
comment: To see where this is in the review pipeline and follow the progress, please have a look at the [project board](https://github.com/orgs/cncf/projects/26/views/1).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
comment: To see where this is in the review pipeline and follow the progress, please have a look at the [project board](https://github.com/orgs/cncf/projects/26/views/1).
comment: To see where this is in the review pipeline and follow the progress, please look at the [definition review board](https://github.com/orgs/cncf/projects/26/views/1).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, lgtm

Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @seokho-son, /lgtm

@iamNoah1 iamNoah1 merged commit 8f8d1ce into cncf:main Sep 16, 2023
6 checks passed
@seokho-son seokho-son deleted the seokho-son-patch-23 branch September 16, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainers Use this label if PR requires maintainers to take action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants