Skip to content
This repository has been archived by the owner on Jun 2, 2024. It is now read-only.

noattachment is true #325

Closed
fengmk2 opened this issue Apr 16, 2014 · 3 comments
Closed

noattachment is true #325

fengmk2 opened this issue Apr 16, 2014 · 3 comments
Assignees
Milestone

Comments

@fengmk2
Copy link
Member

fengmk2 commented Apr 16, 2014

http://r.cnpmjs.org/hummus/1.0.25

image

@fengmk2
Copy link
Member Author

fengmk2 commented Apr 16, 2014

sync again work now http://cnpmjs.org/sync/hummus#logid=3635

sync job need to check dist.size

@fengmk2 fengmk2 added this to the v0.4 milestone Apr 16, 2014
@fengmk2 fengmk2 self-assigned this Apr 16, 2014
@fengmk2
Copy link
Member Author

fengmk2 commented Apr 16, 2014

working on this

@fengmk2
Copy link
Member Author

fengmk2 commented Apr 16, 2014

try {
    // get tarball
    var r = yield *urllib.request(downurl, options);
    var statusCode = r.status || -1;
    if (statusCode === 404) {
      shasum = sourcePackage.dist.shasum;
      return yield *afterUpload({
        url: downurl
      });
    }

dead-horse added a commit that referenced this issue Apr 16, 2014
if download tarball 404, throw err better than ignore it. fixed #325
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant