Skip to content
This repository has been archived by the owner on Jun 2, 2024. It is now read-only.

add put /:name/:tag, close #332 #333

Merged
merged 2 commits into from
Apr 18, 2014
Merged

add put /:name/:tag, close #332 #333

merged 2 commits into from
Apr 18, 2014

Conversation

dead-horse
Copy link
Member

No description provided.

@dead-horse dead-horse added this to the v0.4 milestone Apr 18, 2014
exports.updateTag = function *() {
var version = this.request.body;
var tag = this.params.tag;
var name =this.params.name;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space


var mod = yield Module.get(name, version);
if (!mod) {
this.status = 403;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be 404

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm return 403..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...... got it

@fengmk2
Copy link
Member

fengmk2 commented Apr 18, 2014

LGTM

fengmk2 added a commit that referenced this pull request Apr 18, 2014
@fengmk2 fengmk2 merged commit 6aae538 into master Apr 18, 2014
@fengmk2 fengmk2 deleted the issue332-tag branch April 18, 2014 06:12
@fengmk2
Copy link
Member

fengmk2 commented Apr 18, 2014

厄, 用户权限校验呢?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants