This repository has been archived by the owner on Jun 2, 2024. It is now read-only.
no attachment for html #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengmk2
force-pushed
the
no-attachment-for-html
branch
from
67469f3
to
a6b67f5
Compare
| @@ -351,7 +351,7 @@ exports.download = function *(next) { | |||
| this.length = dist.size; | |||
| } | |||
| this.type = mime.lookup(dist.key); | |||
| this.attachment = filename; | |||
| this.attachment(filename); | |||
There was a problem hiding this comment.
We use attachment in wrong way before...
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.