Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InvalidLinkBear doesn't check multiple links in a single line #1296

Closed
satwikkansal opened this issue Jan 12, 2017 · 1 comment
Closed

InvalidLinkBear doesn't check multiple links in a single line #1296

satwikkansal opened this issue Jan 12, 2017 · 1 comment
Assignees
@satwikkansal
Labels
importance/high type/bug

Comments

@satwikkansal
Copy link
Member

For the content of the file as:
http://www.some.linkthatdoesnotexist.com/ https://www.google.com

The output is:

[MAJOR] InvalidLinkBear:
|    | Broken link - unable to connect to http://www.some.linkthatdoesnotexist.com/

But when switched the order

 https://www.google.com http://www.some.linkthatdoesnotexist.com/

Nothing is detected

Difficulty - low
@Makman2
Copy link
Member

Makman2 commented Jan 13, 2017

uuh that's bad :/

@satwikkansal satwikkansal mentioned this issue Jan 13, 2017
Merged
gosom pushed a commit to gosom/coala-bears that referenced this issue Jul 15, 2017
@satwikkansal
InvalidLinkBear: Multiple links
39ec9a8 
The InvalidLinkBear should analyze all the links
in a line instead of just analyzing the first one.

Fixes coala#1296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@satwikkansal satwikkansal

Labels
importance/high type/bug
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Makman2 @satwikkansal