Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESLintBear still fails ! #727

Closed
sils opened this issue Aug 29, 2016 · 8 comments
Closed

ESLintBear still fails ! #727

sils opened this issue Aug 29, 2016 · 8 comments
Assignees
@AbdealiLoKo
Labels
type/bug

Comments

@sils
Copy link
Member

sils commented Aug 29, 2016

type/bug
@gitmate-bot
Copy link
Collaborator

Thanks for reporting this issue! A coalaian will look at it soon.

sils added a commit that referenced this issue Aug 29, 2016
@sils
ESLintBear: Return on empty output
4c85351 
Fixes #727
@sils sils mentioned this issue Aug 29, 2016
Closed
@AbdealiLoKo AbdealiLoKo self-assigned this Aug 31, 2016
@AbdealiLoKo
Copy link
Contributor

So, to clarify ... the issue is about the fact that ESLintBear breaks down if the file has no issues ?
The unittests don't seem to fail though. Weird.

@AbdealiLoKo
Copy link
Contributor

Nice. The complete ESLintBear is broken.
The tests pass but the output is given is that of the eslint --help because eslint has some problem with the command running by Lint.

@sils
Copy link
Member Author

sils commented Aug 31, 2016

Holy shit

@sils
Copy link
Member Author

sils commented Aug 31, 2016

So, to clarify ... the issue is about the fact that ESLintBear breaks down if the file has no issues ?

Yes

@AbdealiLoKo
Copy link
Contributor

I've tested this out as much as I could, and ESLintBear does not break down for files that have no issues.

In such cases, the output is [{"filePath":"<text>","messages":[],"errorCount":0,"warningCount":0}] which gets parsed correctly as JSON and no results are found.

The eslint --help happens when the file given in is a zero-byte-file (content == ""). In such cases, eslint doesn't know what to do. Causing this error, but we have an if which suppresses it and ignores it.

Closing this, please create a new issue if you face again.

@AbdealiLoKo
Copy link
Contributor

Gah ! I just realized how to reproduce this finally.
This happens when eslint has an error (Like an invalid config file).
So, this is similar to #730 as they both happen for the same reason

@AbdealiLoKo AbdealiLoKo reopened this Sep 2, 2016
AbdealiLoKo added a commit that referenced this issue Sep 2, 2016
@AbdealiLoKo
ESLintBear: Handle corner case if eslint fails
3f409d2 
If eslint fails to run, for example if it gets an invalid config file it
does not know how to handle, earlier the bear would throw a JSON
Decoding error because it wouldn't know how to parse "" (an empty
string). Now this case is handled, and it gracefull doesn't try to
create results in such cases.

Fixes #727
@sils
Copy link
Member Author

sils commented Sep 2, 2016

@AbdealiJK please note that #777 is happening at the same time

AbdealiLoKo added a commit that referenced this issue Sep 3, 2016
@AbdealiLoKo
ESLintBear: Handle corner case if eslint fails
0a681b2 
If eslint fails to run, for example if it gets an invalid config file it
does not know how to handle, earlier the bear would throw a JSON
Decoding error because it wouldn't know how to parse "" (an empty
string). Now this case is handled, and it gracefull doesn't try to
create results in such cases.

Fixes #727
AbdealiLoKo added a commit that referenced this issue Sep 3, 2016
@AbdealiLoKo
ESLintBear: Handle corner case if eslint fails
991f530 
If eslint fails to run, for example if it gets an invalid config file it
does not know how to handle, earlier the bear would throw a JSON
Decoding error because it wouldn't know how to parse "" (an empty
string). Now this case is handled, and it gracefull doesn't try to
create results in such cases.

Fixes #727
AbdealiLoKo added a commit that referenced this issue Sep 3, 2016
@AbdealiLoKo
ESLintBear: Handle corner case if eslint fails
8f47ed9 
If eslint fails to run, for example if it gets an invalid config file it
does not know how to handle, earlier the bear would throw a JSON
Decoding error because it wouldn't know how to parse "" (an empty
string). Now this case is handled, and it gracefull doesn't try to
create results in such cases.

Fixes #727
AbdealiLoKo added a commit that referenced this issue Sep 3, 2016
@AbdealiLoKo
ESLintBear: Handle corner case if eslint fails
6e8a361 
If eslint fails to run, for example if it gets an invalid config file it
does not know how to handle, earlier the bear would throw a JSON
Decoding error because it wouldn't know how to parse "" (an empty
string). Now this case is handled, and it gracefull doesn't try to
create results in such cases.

Fixes #727
AbdealiLoKo added a commit that referenced this issue Sep 3, 2016
@AbdealiLoKo
ESLintBear: Handle corner case if eslint fails
1fc9c0f 
If eslint fails to run, for example if it gets an invalid config file it
does not know how to handle, earlier the bear would throw a JSON
Decoding error because it wouldn't know how to parse "" (an empty
string). Now this case is handled, and it gracefull doesn't try to
create results in such cases.

Fixes #727
@rultor rultor closed this as completed in c60e9f5 Sep 3, 2016
AbdealiLoKo added a commit that referenced this issue Sep 3, 2016
@AbdealiLoKo
ESLintBear: Handle corner case if eslint fails
3464701 
If eslint fails to run, for example if it gets an invalid config file it
does not know how to handle, earlier the bear would throw a JSON
Decoding error because it wouldn't know how to parse "" (an empty
string). Now this case is handled, and it gracefull doesn't try to
create results in such cases.

Fixes #727
gosom pushed a commit to gosom/coala-bears that referenced this issue Jul 15, 2017
@AbdealiLoKo
ESLintBear: Handle corner case if eslint fails
d79b94f 
If eslint fails to run, for example if it gets an invalid config file it
does not know how to handle, earlier the bear would throw a JSON
Decoding error because it wouldn't know how to parse "" (an empty
string). Now this case is handled, and it gracefull doesn't try to
create results in such cases.

Fixes coala#727
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AbdealiLoKo AbdealiLoKo

Labels
type/bug
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AbdealiLoKo @sils @gitmate-bot