Add date filter #42
Merged
Add date filter #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstep
force-pushed
the
date-filter
branch
2 times, most recently
from
333499e
to
d823bf6
Compare
| } | ||
|
|
||
| let date = match input { | ||
| &Value::Str(ref s) => try!(DateTime::parse_from_str(&s, "%d %B %Y %H:%M:%S %z") |
There was a problem hiding this comment.
So the original liquid has a to_date function that I think is a good idea to implement for us as well https://github.com/Shopify/liquid/blob/master/lib/liquid/utils.rb#L63
However, we don't have to do it in this PR. I'll make a follow-up issue.
|
Sorry, I just got around looking at this. Looks great apart from the minor comments! You'll also have to do a rebase from master. Thanks again! |
|
Oh, I didn't notice the update. Thanks, looks great now! 👍 👍 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A date filter implementation for #11 from cobalt-org/cobalt.rs#115.
This change is