feat(filters): Add sort_natural #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epage
added a commit
to epage/liquid-rust
that referenced
this pull request
Jan 14, 2018
Template impact: There is now a consistent approach taken to when a `Value` can be used as a string, whole number, fractional number, bool etc. Examples - Every `Value` is now treated as a string. - Whole numbers are now preserved. - Whole numbers can convert to fractional numbers but not the other way around. - You can convert a fractional number to a whole number using the filters `round`, `ceil`, or `floor`. - Operations on only whole numbers preserve their whole number nature. - for tag ranges, indexing, etc only accept whole numbers Fixes cobalt-org#99 Programmatic impact: This implements the `Value` refactor from cobalt-org#95. `Value` is still an enum but now there is a single `Scalar` variant. This scalar is not an enum but is convertible between each of the common data types. Optimizations are in place to natively store some of these data types. BREAKING CHANGE: `Value`'s API has changed. Conversion behavior within templates has changed.
epage
added a commit
to epage/liquid-rust
that referenced
this pull request
Jan 14, 2018
Template impact: There is now a consistent approach taken to when a `Value` can be used as a string, whole number, fractional number, bool etc. Examples - Every `Value` is now treated as a string. - Whole numbers are now preserved. - Whole numbers can convert to fractional numbers but not the other way around. - You can convert a fractional number to a whole number using the filters `round`, `ceil`, or `floor`. - Operations on only whole numbers preserve their whole number nature. - for tag ranges, indexing, etc only accept whole numbers Fixes cobalt-org#99 Programmatic impact: This implements the `Value` refactor from cobalt-org#95. `Value` is still an enum but now there is a single `Scalar` variant. This scalar is not an enum but is convertible between each of the common data types. Optimizations are in place to natively store some of these data types. BREAKING CHANGE: `Value`'s API has changed. Conversion behavior within templates has changed.
epage
added a commit
that referenced
this pull request
Jan 22, 2018
Features API * **Value:** Control key order ([7ff0fcd](7ff0fcd), closes [#159](#159)) Users * **errors:** * Provide context on compile errors ([c17df1f](c17df1f)) * Report context during render ([73e26cf](73e26cf), closes [#105](#105)) * **filters:** Implement basic `compact` support ([c0eadd5](c0eadd5)) Breaking Changes API * Reduce string cloning ([3d93928](3d93928) Users * **value:** Improve value coercion practices ([ebb4f40](ebb4f40), closes [#99](#99) Performance * Reduce string cloning ([3d93928](3d93928) Bug Fixes API * Remove warning when no-default-features ([8c43de8](8c43de8)) Users * **filters:** date_in_tz can't parse cobalt date ([1dae527](1dae527)) * **value:** Improve value coercion practices ([ebb4f40](ebb4f40), closes [#99](#99)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11