storage: Support stopped Stratis pools #18679
Conversation
|
Stopped pools look like this on the overview now:
Maybe there is a better icon to use for the "Start" action? |
mvollmer
force-pushed
the
storage-stratis-3-r2
branch
from
88e49fa
to
f1115ac
Compare
mvollmer
force-pushed
the
storage-stratis-3-r2
branch
from
f1115ac
to
2ae9792
Compare
|
Most of the uncovered stuff is about Stratis 2 (which only runs on rhel-8 and centos-8) and about showing stopped pools in the overview. I'll modify the test to cover the latter. |
mvollmer
force-pushed
the
storage-stratis-3-r2
branch
from
2ae9792
to
eca64e0
Compare
mvollmer
force-pushed
the
storage-stratis-3-r2
branch
from
eca64e0
to
453867a
Compare
mvollmer
force-pushed
the
storage-stratis-3-r2
branch
from
453867a
to
1009a86
Compare
Stopped pools are a generalization of locked encrypted pools introduced in newer versions of Stratis. Now every kind of pool can be inactive, not just encrypted ones.
martinpitt
force-pushed
the
storage-stratis-3-r2
branch
from
1009a86
to
28ce209
Compare
|
Dang, conflict with Katerina's recent PF cleanup. I fixed the (simple) conflict and FPed your branch. |
| @@ -1029,7 +1029,7 @@ function stratis2_start() { | |||
| .input(passphrase); | |||
| }; | |||
|
|
|||
| client.stratis_unlock_pool = (uuid) => { | |||
| client.stratis_start_pool = (uuid) => { | |||
There was a problem hiding this comment.
This added line is not executed by any test. Details
| @@ -1138,10 +1138,10 @@ | |||
| function stratis2_fetch_manager_properties(proxy) { | |||
| stratis2_fetch_properties(proxy, ["LockedPoolsWithDevs"]).then(values => { | |||
| if (values.LockedPoolsWithDevs) { | |||
| proxy.LockedPools = { }; | |||
| proxy.StoppedPools = { }; | |||
There was a problem hiding this comment.
This added line is not executed by any test. Details
| for (const uuid in values.LockedPoolsWithDevs) { | ||
| const l = values.LockedPoolsWithDevs[uuid]; | ||
| proxy.LockedPools[uuid] = { | ||
| proxy.StoppedPools[uuid] = { |
There was a problem hiding this comment.
This added line is not executed by any test. Details
| @@ -455,9 +455,9 @@ function block_description(client, block) { | |||
| if (config) { | |||
| type = C_("storage-id-desc", "Filesystem (encrypted)"); | |||
| used_for = mount_point; | |||
| } else if (block_stratis_locked_pool) { | |||
| } else if (block_stratis_stopped_pool) { | |||
There was a problem hiding this comment.
This added line is not executed by any test. Details
| type = _("Stratis member"); | ||
| used_for = block_stratis_locked_pool; | ||
| used_for = block_stratis_stopped_pool; |
There was a problem hiding this comment.
This added line is not executed by any test. Details
| !stopped_props.key_description.v[1].v[0]) { | ||
| dialog_open({ | ||
| Title: _("Error"), | ||
| Body: _("This pool can not be unlocked here because its key description is not in the expected format.") |
There was a problem hiding this comment.
These 4 added lines are not executed by any test. Details
| Title: _("Error"), | ||
| Body: _("This pool can not be unlocked here because its key description is not in the expected format.") | ||
| }); | ||
| return; |
There was a problem hiding this comment.
This added line is not executed by any test. Details
| return start(); | ||
| } else { | ||
| return (client.stratis_list_keys() | ||
| .catch(() => [{ }]) |
There was a problem hiding this comment.
This added line is not executed by any test. Details
| .catch(() => [{ }]) | ||
| .then(keys => { | ||
| if (keys.indexOf(key_desc) >= 0) | ||
| return start("keyring"); |
There was a problem hiding this comment.
This added line is not executed by any test. Details
| @@ -80,17 +80,17 @@ export function stratis_rows(client) { | |||
| return client.stratis_pools[path_a].Name.localeCompare(client.stratis_pools[path_b].Name); | |||
| } | |||
|
|
|||
| function cmp_locked_pool(uuid_a, uuid_b) { | |||
| function cmp_stopped_pool(uuid_a, uuid_b) { | |||
There was a problem hiding this comment.
This added line is not executed by any test. Details
Stopped pools are a generalization of locked encrypted pools introduced in newer versions of Stratis. Now every kind of pool can be inactive, not just encrypted ones.