Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extend bridge coverage for internalmetrics #21099

Merged
merged 2 commits into from
Oct 9, 2024
Merged

extend bridge coverage for internalmetrics #21099

merged 2 commits into from
Oct 9, 2024

Commits on Oct 9, 2024

  1. test: assert metric result is not Falsy but False 

    The cpu.core.user metrics can either be a float or a boolean. As `0.0 ==
False` is true do a identity comparison.
    @jelly
    jelly committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    784841c View commit details
    Browse the repository at this point in the history

  2. test: extend internalmetrics coverage by testing calculate_sample_rate 

    Previously we didn't fetch an additional sample so calculate_sample_rate
would only return `False` and not an actual value.
    @jelly
    jelly committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    218f3b6 View commit details
    Browse the repository at this point in the history