system: Keep DBus connection to tuned open over service state changes #21115
Conversation
|
This is an alternative to #21114. It changes less code and starts the service while the dialog is open (which is nice because we already see the spinner while the service starts.) |
This is ok, the DBus service on the other end of a DBusClient can come and go, the DBusClient keeps working. This avoids closing the DBusClient while it is being used by the rest of the code.
mvollmer
force-pushed
the
tuned-straighten-out-dbus-connections-2
branch
from
0df1ee3
to
6614bdb
Compare
| if (state == "not-installed") | ||
| status = _("Tuned is not available"); | ||
| else if (state == "not-running") | ||
| status = _("Tuned is not running"); |
There was a problem hiding this comment.
This added line is not executed by any test.
| else if (state == "not-running") | ||
| status = _("Tuned is not running"); | ||
| else if (active == "none") | ||
| status = _("Tuned is off"); |
There was a problem hiding this comment.
This added line is not executed by any test.
| else if (active == "none") | ||
| status = _("Tuned is off"); | ||
| else if (active == recommended) | ||
| status = _("This system is using the recommended profile"); |
There was a problem hiding this comment.
This added line is not executed by any test.
| else if (active == recommended) | ||
| status = _("This system is using the recommended profile"); | ||
| else | ||
| status = _("This system is using a custom profile"); |
There was a problem hiding this comment.
This added line is not executed by any test.
| Dialogs.show(<TunedDialog updateButton={() => update(tunedDbus)} | ||
| poll={() => poll(tunedDbus)} | ||
| tunedDbus={tunedDbus} tunedService={tunedService} />); |
There was a problem hiding this comment.
These 3 added lines are not executed by any test.
|
No, this doesn't work, unfortunately. Our DBusClient can survive the owner going away and coming back, but there must be an owner when opening the channel. So it works well with auto-activating DBus services that might get restarted, but not here with tuned. Bummer. |
This is ok, the DBus service on the other end of a DBusClient can come and go, the DBusClient keeps working.
This avoids closing the DBusClient while it is being used by the rest of the code.