Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
65352: sql/catalog/typedesc: validate OID range before converting it to ID r=sajjadrizvi a=sajjadrizvi Previously the code to convert an OID to a `descpb.ID` assumed that the OID is larger than a predefined constant. There were no checks to validate the given OID during conversion. As a result, an out-of-range OID could be converted to an invalid descriptor ID without an error. The changes in this PR validate the range of given user-defined OID before conversion, which encourages the user to check the conversion for potential problems. Release note: None Fixes #58414 65746: changefeedccl: Use span frontier when emitting resolved spans. r=stevendanna a=miretskiy Use span frontier to emit change aggregator resolved spans instead of storing additional list of spans to flush. Using span frontier reduces the amount of memory we use (removes duplicate span storage since frontier keeps track of spans anyway). Furthermore, because span frontier merges adjacent spans, we reduce the number of resolved span messages sent to change frontier aggregator, thus making job checkpointing more efficient. Release Notes: None Co-authored-by: Sajjad Rizvi <[email protected]> Co-authored-by: Yevgeniy Miretskiy <[email protected]>
- Loading branch information