-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
storage: stop returning responses directly from TxnWaitQueue
This change removes a small optimization where we would return synthesized PushTxnResponses directly from the TxnWaitQueue when we felt we had enough information to do so. This was useful, but also an abstraction violation. It also opened up the opportunity for this response to get out of sync with what would be returned from properly evaluating the request under latches. This is not likely to come with a noticeable performance impact, in part because the contentionQueue already limits the number of requests that can wait in the TxnWaitQueue for a single transaction at a time. To test this, I ran YCSB A at a few concurrency levels and saw no difference in performance. TODO DURING REVIEW: I'm not 100% sold on this last commit. I'd like to gauge how people feel about it. Release note: None
- Loading branch information
1 parent
e50605d
commit ad0ed45
Showing
5 changed files
with
77 additions
and
139 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.