Merge #101861

101861: sql: add sqlsmith support to test partial visibility of indexes r=rytaft a=rytaft Sometimes generate a partially invisible index instead of a fully invisible index. Informs #82363 Release note: None Co-authored-by: Rebecca Taft <[email protected]>
cockroachdb · Apr 20, 2023 · d9ec744 · d9ec744
2 parents 0ffba81 + 7c32d97
commit d9ec744
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/pkg/internal/sqlsmith/alter.go b/pkg/internal/sqlsmith/alter.go
@@ -367,7 +367,9 @@ func makeCreateIndex(s *Smither) (tree.Statement, bool) {
 	visibility := 1.0
 	if notvisible := s.d6() == 1; notvisible {
 		visibility = 0.0
-		// TODO(rytaft): sometimes generate a float between (0.0,1.0).
+		if s.coin() {
+			visibility = s.rnd.Float64() // [0.0, 1.0)
+		}
 	}
 
 	return &tree.CreateIndex{

diff --git a/pkg/sql/randgen/schema.go b/pkg/sql/randgen/schema.go
@@ -231,7 +231,9 @@ func RandCreateTableWithColumnIndexNumberGeneratorAndName(
 			indexDef.Invisibility = 0.0
 			if notvisible := rng.Intn(6) == 0; notvisible {
 				indexDef.Invisibility = 1.0
-				// TODO(rytaft): sometimes generate a float between (0.0,1.0).
+				if rng.Intn(2) == 0 {
+					indexDef.Invisibility = 1 - rng.Float64()
+				}
 			}
 
 			defs = append(defs, &indexDef)

diff --git a/pkg/workload/schemachange/operation_generator.go b/pkg/workload/schemachange/operation_generator.go
@@ -1050,7 +1050,9 @@ func (og *operationGenerator) createIndex(ctx context.Context, tx pgx.Tx) (*opSt
 	visibility := 1.0
 	if notvisible := og.randIntn(20) == 0; notvisible {
 		visibility = 0.0
-		// TODO(rytaft): sometimes generate a float between (0.0,1.0).
+		if og.randIntn(2) == 0 {
+			visibility = og.params.rng.Float64()
+		}
 	}
 
 	def := &tree.CreateIndex{