Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvserver: TestMergeQueueSeesNonVoters/partially-collocated-voters-only failed #105726

Closed
dt opened this issue Jun 28, 2023 · 1 comment · Fixed by #106760
Closed

kvserver: TestMergeQueueSeesNonVoters/partially-collocated-voters-only failed #105726

dt opened this issue Jun 28, 2023 · 1 comment · Fixed by #106760
Assignees
@miraradeva
Labels
branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-kv KV Team

Comments

@dt
Copy link
Member

dt commented Jun 28, 2023 •
edited
Loading

Unrelated PR build on master hit this: client_merge_test.go:4757: could not add [n2,s2] replicas to range containing /Table/106/1/2: AdminChangeReplicas error: change replicas of r0 failed: descriptor changed: [expected] r0:{-} [<no replicas>, next=0, gen=0] != [actual] r1:/{Min-System/NodeLiveness} [(n1,s1):1, next=2, gen=0] (range replaced)

test.log

Jira issue: CRDB-29164
@dt dt added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Jun 28, 2023
@blathers-crl
Copy link

blathers-crl bot commented Jun 28, 2023

Hi @dt, please add branch-* labels to identify which branch(es) this release-blocker affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl bot added the T-kv KV Team label Jun 28, 2023
@dt dt added the branch-master Failures and bugs on the master branch. label Jun 28, 2023
@dt dt mentioned this issue Jun 28, 2023
Merged
@miraradeva miraradeva mentioned this issue Jul 13, 2023
Merged
craig bot pushed a commit that referenced this issue Jul 17, 2023
@miraradeva @knz
Merge #106760 #106899
b87dec8 
106760: kvserver: deflake TestMergeQueueSeesNonVoters r=tbg a=miraradeva

TestMergeQueueSeesNonVoters was flaky because of a race between turning the merge queue on and off. The merge queue was first turned on via a cluster config, and then turned off using the store directly. However, it's possible for the cluster config to take effect after the queue was turned off via the store and leave the merge queue on for the rest of the test, causing unexpected range merges. The cluster config is actually unnecessary, so this change just removes it.

Fixes: #105726
Epic: CRDB-29164

Release note: None

106899: diagnosticsccl: remove uses of `TODOTestTenantDisabled` r=dhartunian a=knz

Informs #76378 
Epic: CRDB-18499
First commit from #106900.

Followup issue: #106901


Co-authored-by: Mira Radeva <[email protected]>
Co-authored-by: Raphael 'kena' Poss <[email protected]>
@craig craig bot closed this as completed in cd729e1 Jul 17, 2023
@renatolabs renatolabs mentioned this issue Jul 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miraradeva miraradeva

Labels
branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-kv KV Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kvserver: deflake TestMergeQueueSeesNonVoters miraradeva/cockroach
2 participants
@dt @miraradeva