Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importccl: enable importing MySQL SET columns #32560

Closed
knz opened this issue Nov 22, 2018 · 2 comments
Closed

importccl: enable importing MySQL SET columns #32560

knz opened this issue Nov 22, 2018 · 2 comments
Labels
A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) good first issue T-disaster-recovery X-anchored-telemetry The issue number is anchored by telemetry references.
Milestone

Comments

@knz
Copy link
Contributor

knz commented Nov 22, 2018

https://dev.mysql.com/doc/refman/5.7/en/set.html

A SET is a string object that can have zero or more values, each of which must be chosen from a list of permitted values specified when the table is created. SET column values that consist of multiple set members are specified with members separated by commas (,). A consequence of this is that SET member values should not themselves contain commas.

Technically, the MySQL "SET" pseudo-type is a 64-bit bitmask under the hood. Each bit in the bitmask is given a name in the table descriptor.

This can be imported into cockroachdb as an integer.

Epic CRDB-8825

Jira issue: CRDB-4731

@knz knz added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-disaster-recovery labels Nov 22, 2018
@knz knz added the X-anchored-telemetry The issue number is anchored by telemetry references. label Nov 22, 2018
@knz knz added this to the Later milestone Nov 22, 2018
knz added a commit to knz/cockroach that referenced this issue Nov 22, 2018
knz added a commit to knz/cockroach that referenced this issue Nov 26, 2018
knz added a commit to knz/cockroach that referenced this issue Nov 28, 2018
@kurokochin
Copy link
Contributor

kurokochin commented Dec 18, 2021

Hi, I'm interested to work on this. I might need a few pointers regarding what changes needed to be made.

My current understanding:

  • We just want to consider SET as an integer (need to made changes in pkg/ccl/importccl/read_import_mysql.go and modify case mysqltypes.Set from throwing error to define the type def.Type = types.Int)
  • Need to add test inside everything.sql and modify the expected result in everything.cockroach-schema.sql

cc @knz kindly correct me I'm wrong

Thanks in advance!

@dikshant
Copy link

dikshant commented Feb 2, 2023

With IMPORT MYSQLDUMP being deprecated: #93660 and Schema Conversion Tool being better for schema migrations, this is no longer needed and can now be closed.

@dikshant dikshant closed this as completed Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) good first issue T-disaster-recovery X-anchored-telemetry The issue number is anchored by telemetry references.
Projects
Archived in project
Development

No branches or pull requests

5 participants