Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: add unimplemented errors for trigram indexes and functions #51137

Closed
awoods187 opened this issue Jul 8, 2020 · 0 comments · Fixed by #54536
Closed

sql: add unimplemented errors for trigram indexes and functions #51137

awoods187 opened this issue Jul 8, 2020 · 0 comments · Fixed by #54536
Assignees
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@awoods187
Copy link
Contributor

Similarity

root@127.0.0.1:60727/movr> SELECT similarity('word', 'two words');
ERROR: unknown function: similarity()
SQLSTATE: 42883

Using show_trgm() function:

#
root@127.0.0.1:60727/movr> SELECT show_trgm('hello');
ERROR: unknown function: show_trgm()
SQLSTATE: 42883

Word_similarity

root@127.0.0.1:60727/movr> SELECT word_similarity('word', 'two words');
ERROR: unknown function: word_similarity()
SQLSTATE: 42883

Strict_world_similarity

root@127.0.0.1:60727/movr> SELECT strict_word_similarity('word', 'two words');
ERROR: unknown function: strict_word_similarity()
SQLSTATE: 42883

Creating an index:

root@127.0.0.1:60727/movr> CREATE INDEX CONCURRENTLY index_vehicles_on_vehicle_name_trigram
ON vehicles
USING gin (ext gin_trgm_ops);
invalid syntax: statement ignored: at or near "gin_trgm_ops": syntax error
SQLSTATE: 42601
DETAIL: source SQL:
CREATE INDEX CONCURRENTLY index_vehicles_on_vehicle_name_trigram
ON vehicles
USING gin (ext gin_trgm_ops)
               ^
HINT: try \h CREATE INDEX

or

[email protected]:60727/movr> CREATE INDEX trgm_idx ON test_trgm USING GIST (t gist_trgm_ops);
invalid syntax: statement ignored: at or near "gist": syntax error: unimplemented: this syntax
SQLSTATE: 0A000
DETAIL: source SQL:
CREATE INDEX trgm_idx ON test_trgm USING GIST (t gist_trgm_ops)
                                         ^
HINT: You have attempted to use a feature that is not yet implemented.

Please check the public issue tracker to check whether this problem is
already tracked. If you cannot find it there, please report the error
with details by creating a new issue.

If you would rather not post publicly, please contact us directly
using the support form.

We appreciate your feedback.

We also need:

show_limit()
set_limit(real)

https://www.postgresql.org/docs/12/pgtrgm.html

Relates to #41285

@blathers-crl blathers-crl bot added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Jul 8, 2020
@cockroachdb cockroachdb deleted a comment from blathers-crl bot Jul 8, 2020
@solongordon solongordon self-assigned this Aug 25, 2020
@otan otan self-assigned this Sep 17, 2020
@solongordon solongordon removed their assignment Sep 17, 2020
craig bot pushed a commit that referenced this issue Sep 18, 2020
54450: userfile: add userfile telemetry r=pbardea a=adityamaru

Adds telemetry to userfile upload, delete, list, and counts how many
times userfile is used as the import source.

Informs: #53431

Release note: None

54517: sql: backfill partial inverted indexes r=rytaft a=mgartner

This commit adds support for backfilling partial inverted indexes.
After the backfill is complete, the number of entries in the index are
verified to be correct.

Release note: None

54519: sql: implement CREATE EXTENSION syntax r=solongordon a=otan

Refs #51424, #51137 

Release note (sql change): Add support for the CREATE EXTENSION syntax.
This no-ops for PostGIS, and gives unimplemented errors for extensions
we do not yet support but may plan to.

54531: sql: don't allow cross-database sequence owners r=RaduBerinde a=RaduBerinde

#### sql: add more tests for cross-db views

Follow-up to #54475, a few more tests around views:
 - reference to sequence from another database
 - CREATE OR REPLACE

Release note: None

#### sql: don't allow cross-database sequence owners

A sequence can be "owned" by a column. This change disallows setting
owners from tables in other databases and adds a cluster setting to
allow them (false by default).

Informs #54126.

Release note (sql change): creating sequences that are OWNED BY
columns in tables in other databases is now disallowed (and can be
re-enabled via a cluster setting).


Co-authored-by: Aditya Maru <[email protected]>
Co-authored-by: Marcus Gartner <[email protected]>
Co-authored-by: Oliver Tan <[email protected]>
Co-authored-by: Radu Berinde <[email protected]>
@craig craig bot closed this as completed in 3a5c0b9 Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants