Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvprober: implement a prober that sends queries to KV in order to generate signal on the healthiness of KV client & below #61074

Closed
8 of 17 tasks
joshimhoff opened this issue Feb 24, 2021 · 1 comment
Labels
A-kv-observability C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-sre For issues SRE opened or otherwise cares about tracking. T-kv KV Team

Comments

@joshimhoff
Copy link
Collaborator

joshimhoff commented Feb 24, 2021

https://docs.google.com/document/d/1NqsIgizseyMxUBimpE10m6sSnbebQ25VyJRUwxdmJyM/edit

Is your feature request related to a problem? Please describe.
The problem to solve it provide operators & others better signals of the healthiness of kvclient & below.

Operators & others can alert on these signals. CRL can use them to think about how "big" outages are & to understand where in CRDB stack (is KV broken or not?) & keyspace the impact is.

Describe the solution you'd like
Implement a prober that sends queries to KV in order to generate signal on the healthiness of KV client & below. For a POC that does reads only, see #58124.

Describe alternatives you've considered
More discussion in design doc linked above about alternatives.

By 21.2:

Later:

Epic CC-5241

@joshimhoff joshimhoff added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-sre For issues SRE opened or otherwise cares about tracking. A-kv-observability labels Feb 24, 2021
@joshimhoff joshimhoff self-assigned this Feb 24, 2021
@joshimhoff joshimhoff changed the title Implement a prober that sends queries to KV in order to generate signal on the healthiness of KV client & below kvprober: implement a prober that sends queries to KV in order to generate signal on the healthiness of KV client & below Mar 1, 2021
craig bot pushed a commit that referenced this issue Mar 5, 2021
61524: kvprober: add metrics to the registry & catalog r=tbg a=joshimhoff

#61074

**kvprober: add metrics to the registry & catalog**

This commit adds the kvprober metrics to the registry so they are
exported at the prometheus endpoint and tracked in CRDB's time-series
DB. This commit also adds the kvprober metrics to the catalog since
that is required by a unit test.

Release justification: Auxiliary system that is off by default.
Release note: None.

Co-authored-by: Josh Imhoff <[email protected]>
@jlinder jlinder added the T-kv KV Team label Jun 16, 2021
@joshimhoff joshimhoff removed their assignment Sep 1, 2021
@joshimhoff
Copy link
Collaborator Author

I opened some follow up issues. I am closing this one as the main work is DONE!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-kv-observability C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-sre For issues SRE opened or otherwise cares about tracking. T-kv KV Team
Projects
None yet
Development

No branches or pull requests

2 participants