Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc: Filter out virtual computed columns from events #74688

Closed
HonoreDB opened this issue Jan 11, 2022 · 1 comment · Fixed by #74916
Closed

cdc: Filter out virtual computed columns from events #74688

HonoreDB opened this issue Jan 11, 2022 · 1 comment · Fixed by #74916
Assignees
@HonoreDB @sherman-grewal
Labels
A-cdc Change Data Capture C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) docs-done docs-known-limitation T-cdc

Comments

@HonoreDB
Copy link
Contributor

HonoreDB commented Jan 11, 2022 •
edited by celiala
Loading

Configurably, eventually defaulting to "on", changefeeds should not emit a column at all if it was created as VIRTUAL. Right now, changefeeds will misleadingly emit NULL for these columns. In the future we may want an option to actually populate the columns, but this is expensive.

Jira issue: CRDB-12209
Epic: CRDB-8667
@HonoreDB HonoreDB added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-cdc Change Data Capture T-cdc labels Jan 11, 2022
@blathers-crl
Copy link

blathers-crl bot commented Jan 11, 2022

cc @cockroachdb/cdc

@sherman-grewal sherman-grewal mentioned this issue Jan 17, 2022
Merged
sherman-grewal pushed a commit to sherman-grewal/cockroach that referenced this issue Jan 18, 2022
changefeedccl: filter out virtual computed columns from events
62c3fe9 
Resolves cockroachdb#74688

Release note (backward-incompatible change): Changefeeds will
now filter out virtual computed columns from events.
@craig craig bot closed this as completed in d990758 Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HonoreDB HonoreDB

@sherman-grewal sherman-grewal

Labels
A-cdc Change Data Capture C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) docs-done docs-known-limitation T-cdc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

changefeedccl: filter out virtual computed columns from events sherman-grewal/cockroach
3 participants
@HonoreDB @amruss @sherman-grewal