Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: update txn contention insights to use waiting txns as primary contention event instead of blocking txns #87284

Closed
ericharmeling opened this issue Sep 1, 2022 · 0 comments · Fixed by #87440
Closed

ui: update txn contention insights to use waiting txns as primary contention event instead of blocking txns #87284

ericharmeling opened this issue Sep 1, 2022 · 0 comments · Fixed by #87440
Assignees
@ericharmeling
Labels
branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. GA-blocker

Comments

@ericharmeling
Copy link
Contributor

ericharmeling commented Sep 1, 2022 •
edited by cockroach-jira-scripts
Loading

The Transaction Insights overview page currently lists the blocking transactions of transaction contention events as the transactions with "High Contention" insights. We should be using waiting transactions instead. To resolve this issue, we'll need to update the SQL API queries against crdb_internal.transaction_contention_events, and then update some labels and types in the UI.

Jira issue: CRDB-19253
@ericharmeling ericharmeling added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-observability labels Sep 1, 2022
@ericharmeling ericharmeling self-assigned this Sep 1, 2022
@maryliag maryliag added GA-blocker branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 labels Sep 1, 2022
ericharmeling added a commit to ericharmeling/cockroach that referenced this issue Sep 6, 2022
@ericharmeling
ui: update txn contention insights to use waiting txns as event
2edbe2d 
This commit updates the transaction workload insights pages to use the waiting
contended transaction as the primary contention event, rather than the blocking
transaction.

Fixes cockroachdb#87284.

Release justification: bug fixes and low-risk updates to new functionality
Release note: None
@ericharmeling ericharmeling mentioned this issue Sep 6, 2022
Merged
ericharmeling added a commit to ericharmeling/cockroach that referenced this issue Sep 6, 2022
@ericharmeling
ui: update txn contention insights to use waiting txns as event
be87b4a 
This commit updates the transaction workload insights pages to use the waiting
contended transaction as the primary contention event, rather than the blocking
transaction.

Fixes cockroachdb#87284.

Release justification: bug fixes and low-risk updates to new functionality
Release note: None
ericharmeling added a commit to ericharmeling/cockroach that referenced this issue Sep 7, 2022
@ericharmeling
ui: update txn contention insights to use waiting txns as event
a0e181a 
This commit updates the transaction workload insights pages to use the waiting
contended transaction as the primary contention event, rather than the blocking
transaction.

Fixes cockroachdb#87284.

Release justification: bug fixes and low-risk updates to new functionality
Release note: None
craig bot pushed a commit that referenced this issue Sep 8, 2022
@samiskin @knz
@ericharmeling @ajwerner
Merge #87027 #87412 #87440 #87462
3ff179c 
87027: streamingccl: reduce server count in multinode tests r=samiskin a=samiskin

While these tests would pass under stress locally they would fail CI
stress, which may be because we were starting more server processes than
ever before with 4 source nodes, 4 source tenant pods, and 4 destination
nodes.

This PR reduces the node count to 3 (any lower and scatter doesn't
correctly distribute ranges) and only starts a single tenant pod for the
source cluster.

Release justification: test-only change
Release note: None

87412: cli,server: fix --sql-advertise-addr when --sql-addr is not specified r=a-robinson,ajwerner a=knz

Fixes #87040.
Informs #52266.

cc `@a-robinson` 

Release justification: bug fix

Release note (bug fix): The flag `--sql-advertise-addr` now properly
works even when the SQL and RPC ports are shared (because `--sql-addr`
was not specified). Note that this port sharing is a deprecated
feature in v22.2.

87440: ui: update txn contention insights to use waiting txns as event r=ericharmeling a=ericharmeling

This commit updates the transaction workload insights pages to use the waiting
contended transaction as the primary contention event, rather than the blocking
transaction.

Fixes #87284.

https://www.loom.com/share/383fec4297a74ec79d90e46f11def792

Release justification: bug fixes and low-risk updates to new functionality
Release note: None

87462: upgrade/upgrades: allow CreatedAtNanos to be set when validating migration r=ajwerner a=ajwerner

Schema change upgrade migrations to system tables are made idempotent by checking that the descriptor reaches some expected state. In order to ensure that it is in that expected state, some volatile fields need to be masked. We forgot to mask CreatedAtNanos. We also lost the testing which came with these helper functions we use.

The vast majority of this PR is reviving testing from #66889.

Fixes #85228.

Release justification: Import bug fix for backport

Release note (bug fix): Some upgrade migrations perform schema changes on system tables. Those upgrades which added indexes could, in some cases, get caught retrying because they failed to detect that the migration had already occurred due to the existence of a populated field. When that happens, the finalization of the new version can hang indefinitely and require manual intervention. This bug has been fixed.

Co-authored-by: Shiranka Miskin <[email protected]>
Co-authored-by: Raphael 'kena' Poss <[email protected]>
Co-authored-by: Eric Harmeling <[email protected]>
Co-authored-by: Andrew Werner <[email protected]>
@craig craig bot closed this as completed in 653f052 Sep 8, 2022
blathers-crl bot pushed a commit that referenced this issue Sep 8, 2022
@ericharmeling
ui: update txn contention insights to use waiting txns as event
078520e 
This commit updates the transaction workload insights pages to use the waiting
contended transaction as the primary contention event, rather than the blocking
transaction.

Fixes #87284.

Release justification: bug fixes and low-risk updates to new functionality
Release note: None
@blathers-crl blathers-crl bot mentioned this issue Sep 8, 2022
Merged
@kevin-v-ngo kevin-v-ngo mentioned this issue Sep 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericharmeling ericharmeling

Labels
branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. GA-blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: update txn contention insights to use waiting txns as event ericharmeling/cockroach
2 participants
@maryliag @ericharmeling