Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: server: try re-enable TestAdminDecommissionedOperations #101110

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 10, 2023

Backport 1/1 commits from #100993 on behalf of @knz.

/cc @cockroachdb/release


The test is flaky; sadly, the error does not reproduce locally and the precise cause of the flakiness is obscured by #100796.

This commit re-enables the test with the fix for #100796, so that the next CI failure can reveal more details about what went wrong.

Release note: None
Epic: None

Informs #100791 and #100789.


Release justification: add debug details to a failing test

The test is flaky; sadly, the error does not reproduce locally and the
precise cause of the flakiness is obscured by #100796.

This commit re-enables the test with the fix for #100796, so that the
next CI failure can reveal more details about what went wrong.

Release note: None
@blathers-crl blathers-crl bot requested a review from a team April 10, 2023 15:55
@blathers-crl blathers-crl bot requested a review from a team as a code owner April 10, 2023 15:55
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-100993 branch from 9901f7a to dbb8281 Compare April 10, 2023 15:55
@blathers-crl
Copy link
Author

blathers-crl bot commented Apr 10, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz knz requested a review from abarganier April 10, 2023 16:14
Copy link
Contributor

@abarganier abarganier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@knz knz merged commit f0779e9 into release-23.1 Apr 10, 2023
@knz knz deleted the blathers/backport-release-23.1-100993 branch April 10, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants