Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.2: sql: add unimplemented errors and telemetry for plpgsql #102625

Merged
merged 8 commits into from
May 8, 2023
Merged

release-22.2: sql: add unimplemented errors and telemetry for plpgsql #102625

merged 8 commits into from
May 8, 2023

Conversation

e-mbrown
Copy link
Contributor

@e-mbrown e-mbrown commented Apr 28, 2023 •
edited
Loading

Merge after #102610
Backport 7/7 commits from #99517.

/cc @cockroachdb/release

Part of: #98147
Closes: #91569

This PR expands grammar rules and adds unimplemented support for pl/pgsql statements.

sql: Add telemetry for parsable plpgsql statements Is the first commit unique to this PR.

Release Notes: None
Release justification: Adds telemetry to for plpgsql statements, doesnt add functionality.

@e-mbrown e-mbrown requested a review from a team April 28, 2023 16:53
@e-mbrown e-mbrown requested review from a team as code owners April 28, 2023 16:53
@blathers-crl
Copy link

blathers-crl bot commented Apr 28, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@e-mbrown e-mbrown force-pushed the backport22.2-99517 branch 3 times, most recently from 23ad388 to b5f4c59 Compare May 3, 2023 20:57
@e-mbrown e-mbrown requested a review from a team as a code owner May 5, 2023 15:05
chengxiong-ruan
chengxiong-ruan reviewed May 5, 2023
View reviewed changes
pkg/sql/plpgsql/plpgsqltelemetry/stmt_tags.go Outdated
@@ -0,0 +1,6 @@
package plpgsqltelemetry
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need a copyright header!

ZhouXing19 and others added 7 commits May 5, 2023 14:43
@ZhouXing19 @e-mbrown
sql: Add telemetry for parsable plpgsql statements
2e37fff 
Release note: None
@e-mbrown
sql: Add unimplemented errors for plpgsql loops
81be29a 
Unimplemented errors and parser test were added for
`stmt_loop`, `stmt_for",`stmt_foreach_a` and `stmt_while`.

Release note: None
@e-mbrown
sql: Add unimplemented errors for return stmts
e43fddd 
Unimplemented errors and parser test were added for
`stmt_return`.

Release note: None
@e-mbrown
sql: add unimplemented errors for stmt_commit and stmt_rollback
ccff07b 
Unimplemented errors and parser test were added for
`stmt_commit` and `stmt_rollback`.

Release note: None
@e-mbrown
sql: Add unimplemented errors for stmt_perform
ce87d16 
Unimplemented errors and parser test were added for
`stmt_perform`.

Release note: None
@e-mbrown
sql: add unimplemented error for stmt_raise
ea0958a 
Unimplemented errors and parser test were added for
`stmt_raise`.

Release note: None
@e-mbrown
sql: add unimplemented error for stmt_move and stmt_from
af8800d 
Unimplemented errors and parser test were added for
`stmt_move` and `stmt_from`.

Release note: None
@chengxiong-ruan chengxiong-ruan merged commit d134e8f into cockroachdb:release-22.2 May 8, 2023
@e-mbrown e-mbrown deleted the backport22.2-99517 branch May 10, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chengxiong-ruan chengxiong-ruan chengxiong-ruan approved these changes

@cucaroach cucaroach Awaiting requested review from cucaroach cucaroach is a code owner automatically assigned from cockroachdb/sql-queries

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@e-mbrown @cockroach-teamcity @chengxiong-ruan @ZhouXing19