util/parquet: add compression options #102978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
miretskiy
approved these changes
May 9, 2023
pkg/util/parquet/writer.go
Outdated
| var compressionCodecToParquet = map[CompressionCodec]compress.Compression{ | ||
| CompressionNone: compress.Codecs.Uncompressed, | ||
| CompressionGZIP: compress.Codecs.Gzip, | ||
| CompressionZSTD: compress.Codecs.Zstd, |
There was a problem hiding this comment.
are these the only 2 supported by parquet? no snappy? no lz4?
There was a problem hiding this comment.
Uncompressed: Compression(parquet.CompressionCodec_UNCOMPRESSED),
Snappy: Compression(parquet.CompressionCodec_SNAPPY),
Gzip: Compression(parquet.CompressionCodec_GZIP),
Lzo: Compression(parquet.CompressionCodec_LZO),
Brotli: Compression(parquet.CompressionCodec_BROTLI),
Lz4: Compression(parquet.CompressionCodec_LZ4),
Zstd: Compression(parquet.CompressionCodec_ZSTD),
jayshrivastava
force-pushed
the
parquet-compress
branch
from
5f305b2
to
2031bb5
Compare
This change updates the parquet writer to be able to use GZIP, ZSTD, SNAPPY, and BROTLI compression codecs. By default, no compression is used. LZO and LZ4 are unsupported by the library. Epic: https://cockroachlabs.atlassian.net/browse/CRDB-15071 Informs: cockroachdb#99028 Release note: None
jayshrivastava
force-pushed
the
parquet-compress
branch
from
2031bb5
to
dcd521a
Compare
|
bors r=miretskiy |
13 tasks
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the parquet writer to be able to use
GZIP, ZSTD, SNAPPY, and BROTLI compression codecs. By
default, no compression is used. LZO and LZ4 are unsupported
by the library.
Epic: https://cockroachlabs.atlassian.net/browse/CRDB-15071
Informs: #99028
Release note: None