release-23.1: sql: add plpgsql parser for telemetry purposes #103026
Merged
+3,765
−236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the code generation portion of the parser. The parser does not parse statements yet. This commit also creates a base scanner struct so that the plpgsql and sql scanner can share methods. The two scanners have their own language specific scan methods. Release note: None
Adds the first test which parses an empty function or function with bare sql queries. Release note: None
This commit adds `lexer.ReadSqlExpressionStr()` which gives access to the return type of a plpgsql function. This commit also adds grammar rules and AST for `stmt_if` Release note: None
This commit adds AST and grammar rules for `decl_header` and `stmt_assert` Release note: None
This commit adds the AST and grammar rules for `stmt_call`, `stmt_close`, `stmt_dynaexec`, and `stmt_exit` Release note: None
This commit adds the AST and grammar rules for `stmt_assign` and `stmt_getdiag` Release note: None
This commit adds portions of the logic to parse `stmt_case`. Does not yet support ELSE, sql statements in THEN body, or END CASE (it uses an ENDCASE hack). Release note: None
This commit corrects the grammar rules for `stmt_case`. Release note: None
This commit corrects the grammar rules and AST of `stmt_if`, `elsif`, `else` statements. Release note: None
This commit adds logic for `stmt_open` Release note: None
|
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
|
This change is |
This commit makes Statement generic so it can be shared between the sql and plpgsql parsers. Release note: None
e-mbrown
force-pushed
the
backport23.1-98147
branch
from
f609bea
to
0216286
Compare
chengxiong-ruan
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 11/11 commits from #98147.
/cc @cockroachdb/release
Informs: #91569
This commit adds the in use portions of the plpgsql parser from #91606.
Release note: None
Release justification: The PR allows us to parse some plpggsql statements but doesn't add functionality.