Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: sql: add unimplemented errors and telemetry for plpgsql #103132

Merged
merged 7 commits into from
May 16, 2023
Merged

release-23.1: sql: add unimplemented errors and telemetry for plpgsql #103132

merged 7 commits into from
May 16, 2023

Conversation

e-mbrown
Copy link
Contributor

Backport 7/7 commits from #99517.

/cc @cockroachdb/release

Part of: #98147
Closes: #91569

This PR expands grammar rules and adds unimplemented support for pl/pgsql statements.

sql: Add telemetry for parsable plpgsql statements Is the first commit unique to this PR.

Release Notes: None
Release justification: Adds telemetry to for plpgsql statements, doesnt add functionality.

@e-mbrown e-mbrown requested review from chengxiong-ruan and a team May 11, 2023 18:39
@e-mbrown e-mbrown requested review from a team as code owners May 11, 2023 18:39
@e-mbrown e-mbrown requested a review from rytaft May 11, 2023 18:39
@blathers-crl
Copy link

blathers-crl bot commented May 11, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

ZhouXing19 and others added 7 commits May 16, 2023 13:27
@ZhouXing19 @chengxiong-ruan
sql: Add telemetry for parsable plpgsql statements
8bd479a 
Release note: None
@e-mbrown @chengxiong-ruan
sql: Add unimplemented errors for plpgsql loops
5b973e2 
Unimplemented errors and parser test were added for
`stmt_loop`, `stmt_for",`stmt_foreach_a` and `stmt_while`.

Release note: None
@e-mbrown @chengxiong-ruan
sql: Add unimplemented errors for return stmts
3ad0063 
Unimplemented errors and parser test were added for
`stmt_return`.

Release note: None
@e-mbrown @chengxiong-ruan
sql: add unimplemented errors for stmt_commit and stmt_rollback
8a7597b 
Unimplemented errors and parser test were added for
`stmt_commit` and `stmt_rollback`.

Release note: None
@e-mbrown @chengxiong-ruan
sql: Add unimplemented errors for stmt_perform
2d96efc 
Unimplemented errors and parser test were added for
`stmt_perform`.

Release note: None
@e-mbrown @chengxiong-ruan
sql: add unimplemented error for stmt_raise
6251008 
Unimplemented errors and parser test were added for
`stmt_raise`.

Release note: None
@e-mbrown @chengxiong-ruan
sql: add unimplemented error for stmt_move and stmt_from
8a95401 
Unimplemented errors and parser test were added for
`stmt_move` and `stmt_from`.

Release note: None
@chengxiong-ruan chengxiong-ruan requested a review from a team as a code owner May 16, 2023 17:29
@chengxiong-ruan chengxiong-ruan merged commit 0a736c7 into cockroachdb:release-23.1 May 16, 2023
@e-mbrown e-mbrown deleted the backport23.1-99517 branch June 6, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafiss rafiss rafiss approved these changes

@chengxiong-ruan chengxiong-ruan Awaiting requested review from chengxiong-ruan

@rytaft rytaft Awaiting requested review from rytaft rytaft was automatically assigned from cockroachdb/sql-queries

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@e-mbrown @cockroach-teamcity @rafiss @chengxiong-ruan @ZhouXing19