server: Default job wait period to 0 #103134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
renatolabs
approved these changes
May 11, 2023
Avoid test flakes by default job wait period to 0. Release note: None
|
please do run this with bors p=999 when you're ready! It seems to be causing a bunch of flakes |
|
Bors r+ p=999 |
|
Build succeeded: |
miretskiy
pushed a commit
to miretskiy/cockroach
that referenced
this pull request
May 12, 2023
This is a revert of cockroachdb#103134 to reset job wait period to 10s Epic: None Release note: None
craig bot
pushed a commit
that referenced
this pull request
May 15, 2023
103131: util/parquet: add crdb metadata to parquet files r=miretskiy a=jayshrivastava util/parquet: add option to write kv metadata to files This change adds an option to the writer which allows the caller to write arbitrary kv metadata to parquet files. This is useful for testing purposes. Informs: #99028 Epic: https://cockroachlabs.atlassian.net/browse/CRDB-15071 Release note: None --- util/parquet: remove dependency on writer to read parquet files Previously, the test utils used to read parquet files would require the writer as an argument. The main reason the writer was required is that the writer contained crdb-specific type information which could be used to decode raw data until crdb datums. With this change, the writer is updated to write this crdb-specific type information to the parquet file in its metadata. The reader is updated to the read type information from the file metadata. There is a new test utility function `ReadFile(parquetFile string)` which can be used to read all datums from a parquet file without providing any additional type information. The function also returns metadata since it is possible for users of the `Writer` to write arbitrary metadata and such users may need this metadata in testing. Informs: #99028 Epic: https://cockroachlabs.atlassian.net/browse/CRDB-15071 Release note: None 103181: server: Default job wait time to 10s r=miretskiy a=miretskiy This is a revert of #103134 to reset job wait period to 10s Epic: None Release note: None Co-authored-by: Jayant Shrivastava <[email protected]> Co-authored-by: Yevgeniy Miretskiy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid test flakes by default job wait period to 0.
Epic: None
Release note: None