Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev,generate-cgo: externalize cgo files gen into a seperate binary #103140

Closed
wants to merge 2 commits into from
Closed

dev,generate-cgo: externalize cgo files gen into a seperate binary #103140

wants to merge 2 commits into from

Commits on May 11, 2023

  1. dev,generate-cgo: externalize cgo files gen into a seperate binary 

    Previously, we only needed to gen cgo files using `dev` so that
was were that logic lived. Now, we need to gen cgo files outside
dev to fix an issue with gcassert [see cockroachdb#65485].

This code change externalizes the code into a separate binary
and let's `dev gen cgo` point to it.

Release note: None
Epic: None

Informs cockroachdb#65485
    healthy-pod committed May 11, 2023
    Configuration menu
    Copy the full SHA
    c44cb55 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. gcassert: upgrade gcassert and generate cgo files before running it 

    Release note: None
Epic: none

Closes cockroachdb#65485
    healthy-pod committed May 15, 2023
    Configuration menu
    Copy the full SHA
    de5e2c0 View commit details
    Browse the repository at this point in the history