changefeedccl: support the resolved option with format=parquet #104283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jayshrivastava
force-pushed
the
parquet-resolved
branch
5 times, most recently
from
bc6ff2d
to
1ac4580
Compare
jayshrivastava
changed the title
resolved option with format=parquet
miretskiy
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
I think we should have a short rel note.
Reviewed 9 of 9 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @jayshrivastava and @samiskin)
pkg/ccl/changefeedccl/parquet_sink_cloudstorage.go line 149 at r1 (raw file):
var writer *parquet.Writer writer, err = newParquetWriter(sch, &buf, parquetSink.wrapped.testingKnobs)
can we check -- when we construct this sink -- if resolved option is set, and if so, construct writer once?
pkg/ccl/changefeedccl/parquet_test.go line 176 at r1 (raw file):
sqlDB.Exec(t, `CREATE TABLE foo (a INT PRIMARY KEY)`) foo := feed(t, f, `CREATE CHANGEFEED FOR foo WITH format=parquet, resolved`)
you probably want to specify resolved= some small value... otherwise, this test would run for 30 seconds or so?
jayshrivastava
force-pushed
the
parquet-resolved
branch
from
1ac4580
to
228aee6
Compare
Previously, `format=parquet` and `resolved` could not be used together when running changefeeds. This change adds support for this. The release note is being left intentionally blank for a future commit. Informs: cockroachdb#103129 Release note: None
jayshrivastava
force-pushed
the
parquet-resolved
branch
2 times, most recently
from
8720056
to
07101ad
Compare
|
bors r=miretskiy |
13 tasks
|
Build failed (retrying...): |
|
Build succeeded: |
This was referenced Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
format=parquetandresolvedcould not be usedtogether when running changefeeds. This change adds support for
this.
The release note is being left intentionally blank for a future
commit.
Informs: #103129
Release note: None