roachtest: require stability in rebalance by load roachtests #107834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
kvoli
changed the title
The `rebalance/by-load` roachtests collect timeseries data from the cluster. If these tests started quickly enough, no datapoints could exist which would cause an out of bounds array error. Handle the no datapoints case, and log a message without failing the test. Informs: cockroachdb#107247 Release note: None
The `rebalance/by-load` roachtests would immediately pass once the balance target was hit. However, it was possible that the cluster was only transiently balanced. Bump the timeout of all tests to be uniformly 10 minutes, from a previous 5-10 minutes, require that the load remains balanced for at least 1 minute to pass. Informs: cockroachdb#107247 Release note: None
kvoli
force-pushed
the
230728.rebalance-by-load-stability
branch
from
4361aae
to
e1f4739
Compare
kvoli
requested review from
smg260,
renatolabs and
andrewbaptist
and removed request for
a team
|
I stressed the tests for 15 runs each without failure. Should be good to take a look. |
|
|
|
TYFTR bors r=andrewbaptist |
|
👎 Rejected by too few approved reviews |
|
@andrewbaptist could you re-approve? I don't think it went through. |
|
Thanks bors r=andrewbaptist |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rebalance/by-loadroachtests collect timeseries data from thecluster. If these tests started quickly enough, no datapoints could
exist which would cause a out of bounds array exception.
Handle the no datapoints case, and log a message without failing the
test.
Informs: #107247
The
rebalance/by-loadroachtests would immediately pass once thebalance target was hit. However, it was possible that the cluster was
only transiently balanced.
Bump the timeout of all tests to be uniformly 10 minutes, from a
previous 5 minutes, require that the load remains balanced for at
least 1 minute to pass.
Informs: #107247
Release note: None