Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logictest: avoid FATAL during cleanup #108924

Merged
merged 1 commit into from
Aug 17, 2023
Merged

logictest: avoid FATAL during cleanup #108924

merged 1 commit into from
Aug 17, 2023

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Aug 17, 2023

This prevents the test from failing if there is an error closing a connection at the end of the test. There is no strong need for us to assert that closing the connection worked.

fixes #108833
Release note: None

@rafiss
logictest: avoid FATAL during cleanup
9d2c598 
This prevents the test from failing if there is an error closing a
connection at the end of the test. There is no strong need for us to
assert that closing the connection worked.

Release note: None
@rafiss rafiss added the backport-23.1.x Flags PRs that need to be backported to 23.1 label Aug 17, 2023
@rafiss rafiss requested review from fqazi, yuzefovich and a team August 17, 2023 18:54
@cockroach-teamcity
Copy link
Member

This change is Reviewable

annrpom
annrpom approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@annrpom annrpom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @fqazi and @yuzefovich)

@rafiss
Copy link
Collaborator Author

rafiss commented Aug 17, 2023

flake was "teamcity agent removed" https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Ci_Tests_LocalRoachtest/11367553?hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildChangesSection=true

bors r+

yuzefovich
yuzefovich approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 2 of 0 LGTMs obtained (waiting on @fqazi)

@craig
Copy link
Contributor

craig bot commented Aug 17, 2023

Build succeeded:

@craig craig bot merged commit 02065f5 into cockroachdb:master Aug 17, 2023
2 checks passed
@blathers-crl blathers-crl bot mentioned this pull request Aug 17, 2023
Merged
@rafiss rafiss deleted the fix-logictest-close-connection branch August 18, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuzefovich yuzefovich yuzefovich approved these changes

@annrpom annrpom annrpom approved these changes

@fqazi fqazi Awaiting requested review from fqazi

Assignees
No one assigned
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Milestone
No milestone
4 participants
@rafiss @cockroach-teamcity @yuzefovich @annrpom